[NOT A BUG] Multiple errors & bugs in SG 2.0 - not ready for production.

Sperber

Member
Multiple errors in XF 2.1 / latest SG:

After upgrade from previous SG version, some processes haven´t been finished. If I try to process them manually, it results in this:
Code:
InvalidArgumentException: Unknown column tlg_group_id on XF:Node in src/XF/Mvc/Entity/Finder.php at line 1569

    XF\Mvc\Entity\Finder->resolveFieldToTableAndColumn() in src/XF/Mvc/Entity/Finder.php at line 595
    XF\Mvc\Entity\Finder->columnSqlName() in src/XF/Mvc/Entity/Finder.php at line 267
    XF\Mvc\Entity\Finder->buildCondition() in src/XF/Mvc/Entity/Finder.php at line 132
    XF\Mvc\Entity\Finder->where() in src/addons/Truonglv/Groups/Job/NodeParent.php at line 31
    Truonglv\Groups\Job\NodeParent->run() in src/XF/Job/Manager.php at line 253
    XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 195
    XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 79
    XF\Job\Manager->runQueue() in src/XF/Admin/Controller/Tools.php at line 139
    XF\Admin\Controller\Tools->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 321
    XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
    XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
    XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
    XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
    XF\App->run() in src/XF.php at line 390
    XF::runApp() in admin.php at line 13
Trying to add a mdia embed to the XFMG:
Code:
[B]TypeError[/B]: Argument 1 passed to Truonglv\Groups\App::getGroupIdFromEntity() must be an instance of XF\Mvc\Entity\Entity, null given, called in /var/www/vhosts/mysite.org/httpdocs/community/src/addons/Truonglv/Groups/XFMG/Pub/Controller/Media.php on line 34 in [B]src/addons/Truonglv/Groups/App.php[/B] at line [B]182[/B]

[LIST=1]
[*] [B]Truonglv\Groups\App::getGroupIdFromEntity()[/B] in [B]src/addons/Truonglv/Groups/XFMG/Pub/Controller/Media.php[/B] at line [B]34[/B]
[*] [B]Truonglv\Groups\XFMG\Pub\Controller\Media->actionView()[/B] in [B]src/XF/Mvc/Dispatcher.php[/B] at line [B]321[/B]
[*] [B]XF\Mvc\Dispatcher->dispatchClass()[/B] in [B]src/XF/Mvc/Dispatcher.php[/B] at line [B]248[/B]
[*] [B]XF\Mvc\Dispatcher->dispatchFromMatch()[/B] in [B]src/XF/Mvc/Dispatcher.php[/B] at line [B]100[/B]
[*] [B]XF\Mvc\Dispatcher->dispatchLoop()[/B] in [B]src/XF/Mvc/Dispatcher.php[/B] at line [B]50[/B]
[*] [B]XF\Mvc\Dispatcher->run()[/B] in [B]src/XF/App.php[/B] at line [B]2177[/B]
[*] [B]XF\App->run()[/B] in [B]src/XF.php[/B] at line [B]390[/B]
[*][B]XF::runApp()[/B] in [B]index.php[/B] at line [B]20[/B]
[/LIST]
Another error in the server log:
Code:
InvalidArgumentException: Unknown column tlg_group_id on XF:Node src/XF/Mvc/Entity/Finder.php:1569

Stack-Trace

#0 src/XF/Mvc/Entity/Finder.php(595): XF\Mvc\Entity\Finder->resolveFieldToTableAndColumn('tlg_group_id', true)
#1 src/XF/Mvc/Entity/Finder.php(267): XF\Mvc\Entity\Finder->columnSqlName('tlg_group_id', true)
#2 src/XF/Mvc/Entity/Finder.php(132): XF\Mvc\Entity\Finder->buildCondition('tlg_group_id', '>', 0)
#3 src/addons/Truonglv/Groups/Job/NodeParent.php(31): XF\Mvc\Entity\Finder->where('tlg_group_id', '>', 0)
#4 src/XF/Job/Manager.php(253): Truonglv\Groups\Job\NodeParent->run(G)
#5 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#6 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#7 src/XF/Admin/Controller/Tools.php(139): XF\Job\Manager->runQueue(true, 8)
#8 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(ThemeHouse\QAForums\XF\Admin\Controller\Tools), NULL)
#10 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(ThemeHouse\QAForums\XF\Admin\Controller\Tools), NULL)
#11 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#12 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#13 src/XF.php(390): XF\App->run()
#14 admin.php(13): XF::runApp('XF\\Admin\\App')
#15 {main}
Add-on design errors:

1. When adding forums there is an option missing, to not show them on forums_list. If a user adds a group forum this gets instantly shown on forums_list and that is the last thing you want, since this it effects how your main page looks and you don´t want to have a well sorted and arranged forums_list with an endless list of public visible group forums - or visible group forums at all. by now the only way to avoid that is, to restrict visibility for the forum node. But if you do that, the next problem arises:

2. When you have restricted the visibilty of the category where your group forums go to, the navigation on breadcrumb in /groups/[test.1]/discussions looks like Groups > [Main forums category] > [Groups forum name] > [Social group name] with the corresponding links. That makes no sense, since when you have restricted visibility for the [Main forums category] the user is redirected to the forums_list, but won´t find any groups. Also, when browsing the [Social group forums] the breadcrumbs should only link to the forums section within that particular group, like [Social group name] > [Discussions] > [Social group forum name / internal category] > [Social group thread title]. That way people don´t get confused and all links stay in that single group, providing the user easy navigation.

3. Sidebar. When you have set up a sidebar in your main forums threads, the sidebar also shows on all group forum threads. This is consuming a vast amount of space there, since the navigation sidebar to the left is already there and the width of the thread itself shrinks to a tiny little and hard to read text. There really is the need for an option, to completly disable the sidebar in group forums and I would like to urge you, to implement this.

4. If you have set up the first forum in a social group, there is no obvious and easy to reach link to add a second and third. Please add a persisting "Add forum" button to the top right in the Discussions section, because under the settings wheel normal users will never find that option ;)

5. Repositioning of cover photo dosn´t work.

6. Group avatar is cropped:
2960
 
Top