Image Optimizer for XF 2.0 [Paid] 2.2.1

[Wanderer]

Even after:
1) installing addon version 3.0.0 and updating it
2) downloading the latest webp from https://developers.google.com/speed/webp/download and installing it
3) re-running the setup file
3) going through the addon's file path references for pngquant, jpegoptim, gifsicle and cwebp to verify they work and are updated

This add-on STILL deletes my image files, and in a way that prevents me from removing the broken images via the admin attachments interface, unless I manually re-create their missing *.data files.

Here's an example of the file deletion bug from the debug log:

2024-08-02 03:51:02 Process images $contentType=attachment_data $lastRunId=122774 $images=5
2024-08-02 03:51:02 Begin optimize $id=122775
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AttachmentData:nSuccess
2024-08-02 03:51:04 file_hash changed ed405e481ec1474d7418ca1ca2a99772 -> b05ecac977420436fc35c11c40f1704f
2024-08-02 03:51:04 Copying /var/www/html/forum/internal_data/temp/tio_TxFiTm1722570662886 to internal-data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.data
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AbstractData::removeAbstractFile(internal-data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.data)
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AbstractData::removeAbstractFile(data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.jpg)
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AttachmentData:nSuccess -> OK

Note that it SAYS it copied to internal-data://attachments/122/.... but it doesn't actually copy the file. It will happily update the database with the new file hash of the file, it will happily delete the old version of the file... but it won't save the new version of the file.

 

[eva2000]

Even after:
1) installing addon version 3.0.0 and updating it
2) downloading the latest webp from https://developers.google.com/speed/webp/download and installing it
3) re-running the setup file
3) going through the addon's file path references for pngquant, jpegoptim, gifsicle and cwebp to verify they work and are updated

This add-on STILL deletes my image files, and in a way that prevents me from removing the broken images via the admin attachments interface, unless I manually re-create their missing *.data files.

Here's an example of the file deletion bug from the debug log:

Note that it SAYS it copied to internal-data://attachments/122/.... but it doesn't actually copy the file. It will happily update the database with the new file hash of the file, it will happily delete the old version of the file... but it won't save the new version of the file.

Wanderermaybe the deletion step can have a check to verify the file has been copied first?

 

[Truonglv]

How can we recover deleted images ?
i used a backup to revocer them but even if they are accessible using the direct link some of them are not displayed in the browser.
I think it's because the size difference.
is it a way to rerun the optimiser on these specific images or all to update that ?

aanaSadly, there is no way to recover it

 

[aana]

Sadly, there is no way to recover it

TruonglvTruonglv
Can't your addon reprocess all the images ?

 

[Truonglv]

Truonglv
Can't your addon reprocess all the images ?

aanaYes if you reset offset it will run over again.

 

[aana]

Truonglv Nice add-on.
i got the problem of image deleted when optimized then i updated the add-on.

Now it's good but, i tried to recover old images but using backup. Image are now accessible in direct link as attachment. but some are not display ed in the post, instead it's appear broked.
i think it's because of the differente size before/after optimize.
How can i recover that ?
is it possible to run the optimze on specific attachments ?

 

[Truonglv]

Truonglv Nice add-on.
i got the problem of image deleted when optimized then i updated the add-on.

Now it's good but, i tried to recover old images but using backup. Image are now accessible in direct link as attachment. but some are not display ed in the post, instead it's appear broked.
i think it's because of the differente size before/after optimize.
How can i recover that ?
is it possible to run the optimze on specific attachments ?

aanaThank you for give more details. In this case you need custom scripts to rebuild attachment size from database with disk

 

[aana]

Thank you for give more details. In this case you need custom scripts to rebuild attachment size from database with disk

TruonglvThanks Truonglv
can you tell me what size should be taken ?
i mean which command would give me the correct size to update in the DB, also in which table to update it ?

 

[aana]

Thank you for give more details. In this case you need custom scripts to rebuild attachment size from database with disk

TruonglvFor people with this problem, the naive way:

Get the data_id for specific attachment id list

SELECT data_id FROM xf_attachment WHERE attachment_id IN (ID, ID, ID, ... );

Get the size of all concerned files, directly on the server

ls -la internal_data/attachments/FIRST_2-3_digit_of_data_id/data_id-*.data | awk '{print $5}'

Update the DB with correct size

UPDATE `xf_attachment_data` SET `file_size` = 'SIZE' WHERE `xf_attachment_data`.`data_id` = DATA_ID;