Image Optimizer for XF 2.0

Image Optimizer for XF 2.0 [Paid] 2.2.1

PayPal: $29.00
Overview Updates (42) Discussion
Even after:
1) installing addon version 3.0.0 and updating it
2) downloading the latest webp from https://developers.google.com/speed/webp/download and installing it
3) re-running the setup file
3) going through the addon's file path references for pngquant, jpegoptim, gifsicle and cwebp to verify they work and are updated

This add-on STILL deletes my image files, and in a way that prevents me from removing the broken images via the admin attachments interface, unless I manually re-create their missing *.data files.

Here's an example of the file deletion bug from the debug log:
2024-08-02 03:51:02 Process images $contentType=attachment_data $lastRunId=122774 $images=5
2024-08-02 03:51:02 Begin optimize $id=122775
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AttachmentData::onSuccess
2024-08-02 03:51:04 file_hash changed ed405e481ec1474d7418ca1ca2a99772 -> b05ecac977420436fc35c11c40f1704f
2024-08-02 03:51:04 Copying /var/www/html/forum/internal_data/temp/tio_TxFiTm1722570662886 to internal-data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.data
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AbstractData::removeAbstractFile(internal-data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.data)
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AbstractData::removeAbstractFile(data://attachments/122/122775-074a64ceeca98ce0868bf88454799256.jpg)
2024-08-02 03:51:04 Truonglv\ImageOptimizer\ContentData\AttachmentData::onSuccess -> OK
Click to expand...
Note that it SAYS it copied to internal-data://attachments/122/.... but it doesn't actually copy the file. It will happily update the database with the new file hash of the file, it will happily delete the old version of the file... but it won't save the new version of the file.
 
Wanderer said:
Even after:
1) installing addon version 3.0.0 and updating it
2) downloading the latest webp from https://developers.google.com/speed/webp/download and installing it
3) re-running the setup file
3) going through the addon's file path references for pngquant, jpegoptim, gifsicle and cwebp to verify they work and are updated

This add-on STILL deletes my image files, and in a way that prevents me from removing the broken images via the admin attachments interface, unless I manually re-create their missing *.data files.

Here's an example of the file deletion bug from the debug log:

Note that it SAYS it copied to internal-data://attachments/122/.... but it doesn't actually copy the file. It will happily update the database with the new file hash of the file, it will happily delete the old version of the file... but it won't save the new version of the file.
Click to expand...
Wanderermaybe the deletion step can have a check to verify the file has been copied first?
 
↑View previous replies…
aana said:
How can we recover deleted images ?
i used a backup to revocer them but even if they are accessible using the direct link some of them are not displayed in the browser.
I think it's because the size difference.
is it a way to rerun the optimiser on these specific images or all to update that ?
Click to expand...
aanaSadly, there is no way to recover it
 
Truonglv Nice add-on.
i got the problem of image deleted when optimized then i updated the add-on.

Now it's good but, i tried to recover old images but using backup. Image are now accessible in direct link as attachment. but some are not display ed in the post, instead it's appear broked.
i think it's because of the differente size before/after optimize.
How can i recover that ?
is it possible to run the optimze on specific attachments ?
 
aana said:
Truonglv Nice add-on.
i got the problem of image deleted when optimized then i updated the add-on.

Now it's good but, i tried to recover old images but using backup. Image are now accessible in direct link as attachment. but some are not display ed in the post, instead it's appear broked.
i think it's because of the differente size before/after optimize.
How can i recover that ?
is it possible to run the optimze on specific attachments ?
Click to expand...
aanaThank you for give more details. In this case you need custom scripts to rebuild attachment size from database with disk
 
Truonglv said:
Thank you for give more details. In this case you need custom scripts to rebuild attachment size from database with disk
Click to expand...
TruonglvFor people with this problem, the naive way:

Get the data_id for specific attachment id list
SQL: 
SELECT data_id FROM xf_attachment WHERE attachment_id IN (ID, ID, ID, ... );

Get the size of all concerned files, directly on the server
Bash: 
ls -la internal_data/attachments/FIRST_2-3_digit_of_data_id/data_id-*.data | awk '{print $5}'

Update the DB with correct size
SQL: 
UPDATE `xf_attachment_data` SET `file_size` = 'SIZE' WHERE `xf_attachment_data`.`data_id` = DATA_ID;
 
aana said:
Truonglv Nice add-on.
i got the problem of image deleted when optimized then i updated the add-on.

Now it's good but, i tried to recover old images but using backup. Image are now accessible in direct link as attachment. but some are not display ed in the post, instead it's appear broked.
i think it's because of the differente size before/after optimize.
How can i recover that ?
is it possible to run the optimze on specific attachments ?
Click to expand...
aanaHi! It's very depressing. I really don't want to upload hundreds of GB of images from a backup. I haven't updated yet. And now I'm afraid.
Can you please add details how it had happened? Have you .webp (and webp optimisation enabled)? Or it was original usual formats?
 
↑View previous replies…
topas said:
Hi! It's very depressing. I really don't want to upload hundreds of GB of images from a backup. I haven't updated yet. And now I'm afraid.
Can you please add details how it had happened? Have you .webp (and webp optimisation enabled)? Or it was original usual formats?
Click to expand...
topasDisable the add on before update your forum, then get the last version of the addon (3.0.1 for xenforo 2.3). You will not have this problem.

also, the add on only update few images at time, even if you forgot to disable it, you will just need to upload few images.
 
aana said:
Disable the add on before update your forum, then get the last version of the addon (3.0.1 for xenforo 2.3). You will not have this problem.

also, the add on only update few images at time, even if you forgot to disable it, you will just need to upload few images.
Click to expand...
aanaThanks a lot for your reply. Got it.
So you haven't disabled addon before updating to 2.3 and this caused you to make such mistakes?
 
topas said:
At least the reason is clear and what not to do. Thank you a lot for answers and experience!
Click to expand...
topasJust a note... you should always disable ALL add-ons prior to an XF upgrade (not to mention making a full backup). Then after the upgrade do any necessary upgrades to your add-ons while they are disabled. After they are upgraded they will re-enable themselves.
I quit using this add-on after I upgraded to XF 2.3.4 as I no longer getting any large images processed in the add-on log like I had prior to the upgrade, and that behavior was similar to when the add-on was deleting images during it's processing/optomizing.
Was leery of more images being deleted and it was simply easier (but not better) to use the built in WebP optimization in XF and adjust the compression/optimizataion via the config.php settings.
I would have really preferred to continue using this add-on but with the fact that the developer is rarely around to respond to questions it worried me.
Another issue that I discovered is that apparently it only works on the forum images. If you have images uploaded via any other add-on (either 1st party like XFRM or 3rd party) this add-on does not even touch them. And since I have a heavy reliance on XFMG on my site, I lose about 1/2 of the storage due to it not optimizing those images.
 
Last edited:
You must log in or register to reply here.
Back
Top