Not a Bug Group image never gets "304 Not modified"

[Mtor]

Hi,

While optimizing my customer website speed, I found out that due to the way you call the cover images, they are always loaded by the browser from the server.

Indeed, the browser always load them and the don't get a 304 Not modified if they in fact aren't modified.

I think it's because of that bit of code inside the template :

<div class="coverImg"><span style="background-image:url({xen:helper teamCover, $team, $team, 0})"></span></div>

The helper returns a base64 image, hence not cached in any manner.

That's a bit annoying if you want to have a medium number of groups per page and still keep the site fast.

Clément

 

[Mtor]

Just use the debugger in chrome and you'll see.

Attached a screenshot, the group images are loaded everytime and never cached at all seen from a browser standpoint.

 

[Truonglv]

Just use the debugger in chrome and you'll see.

Attached a screenshot, the group images are loaded everytime and never cached at all seen from a browser standpoint.

MtorIt is as designed. The folder data just store public attachments. Not like xenforo attachment has controller control it, my add-on did not. And many other add-on did same.

 

[Mtor]

I don't share that opinion but well, it's your choice.

But at least, it would be better if you had it loaded through a css file to have it 304 not modified instead of having in pure html like that (it's big but I removed lots of chars) :

<span style="background-image:url(data:image/jpeg;base64,iVBORw0KGgoAAAANSUhEUgAABgAAAAINCAYAAAD4P7SmAAAgAElEQVR42uzdd5xdZZ044O/UTHqf9EZ6DyRAEkhCSaGKiAgCFgQEWWxrYcWyiqy6awX5YVtk1VURlaVKR1oQSEIgQAghCYEU0nubyczk9weLAkuSc2bunXLmeT4f/zC8986557ztvN+3FHT76I/3BQAAAAAAkCmFbgEAAAAAAGSPAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGSQAAAAAAAAAGS3RJ9Nk75y3d7+oV/UR9BX0FmpOsT5hSX4Oysj8HHGlcvXlH4v1T+3Wtn8GkAd3aJ067auP2eruRO/bsjb8+91r89bnXIiKiqLAgxg0oj2NH94uZY/vXaR/aT58yIX73aOObkba7Ml0AoEPrFvUaAEgzkzIi3ezFrOWbNC8nEW/MhthhSXCjk6bOG9i9Q5QUFcbeagfB1ZY2klzr26VtihfYxhUAWLN5Z+K0+dqCrKiwIM46eniqz9zwwIL40n8/IvMl1CnhfvNv9i3Uowf24HOvxuYde6JjghnZM8YNiB/ePvfv/3/6mP6J/06a8wb0E/UV9BXIsjQTpnqmqPca0+9TX4Oy8m4KD9zg70j8Rf26ts/7KcodWrdIfNBVRMTLr29usBtbXbMv5i1dG9+75amY+Y2bYuLlv4kf3T43Nu/Yk/q7WrUoiYtnjm10mWfLznS/pb6Wtb6pXcq/t6UWzyYr+WZlys599ybYGWoO0tR5xUWFMax3ZzetDrSR5FK/ru1SzVx/fdOORnX9a7YkDwB0aFOWl2s4alivVGXgmVfWxhW/NfifRpog1bqtB88Tzb0era7ZF3fOW5oo7bj+5dHlLdeWdPufNZt3xOOLVtXpOvUT9RUgO2UyeX02qEfHaGrnAKuvQVnZnwMGABau2JD8iwoLYkSf/A4mHXpIt1TplzSiDsvydVvjOzc/EYd/4Vfxs3ueSf359x45pBEWmHSDD/26tq/X6xvYPd1huys2NL4ZLvWVb15dvy3V9w7u0VGL0QgtXr0pVfrxA7u7aXWgjSSXRvfrmip9YxuUWZsiAFDevlVeruHo4b1Tpf/6jbMte0+hpKgw1fZxSfpV6tHkh/MWFhbE8WP7RUREi5KixPn91qeW1Pka9RP1FSArlq7dkjhtWWlxDOzetOoz9TUoK/vtZxzoPy54dX2qLzt8UI+8XuxRw3qlSr9o1cZGd8N37Nkb/3rjY/HZXz6Q6nO9O7eN/uXtG1mB2Zoq/ZFDetTr9aXNj2l/T5byzXMpy/r4gd2Cxuf51zakSn/aEYPctDpoTm1kmkPSG/Ph8I3Z1JF9UqVPG/DLtzQrADq3aZmXGXWj+iYPoqzcuD2eWLxaxkthWO/OUVyU/BDgJAOH3jUiHl+0KtZsTjapZta4ARHxRrAr6UzxW55cXOdr1E/UV0DfKCteWpWu/zQm5QSNhqa+BmVlv23RARv8lRtjV4qDf86YmN9Z6jPGDkicdvvuynh62dpGe+N//+iLcfucdDNyRvXt0qh+Q9rBxiMG96zX60tbQNN20LOUb9KWlTRlkfqzaceeVJ3aIwf3jB4dW7txtdSc2sjKqurEafO1v3vWHTe6X5Nus1an2JKosLAgurTL/SqAQ1Ks/Hv2lXUyXUppBw5fShCk8q7xhqSz9KeN7BMlRYUxfUyy+mL5uq0xPwd5XT9RXwF9o6xIO+h38viBTer3qa9BWdmfAAAAAAAAJEgAAAAAAAECCBAAAAAAAAJAgAQAAAAAAACRIAAAAAAAAAAkSAAAAAAAAQIIEAAAAAAAAkCABAAAAAAAAJEgAAAAAAAAACRIAAAAAAABAggQAAAAAAACQIAEAAAAAAAAkSAAAAAAAAAAJEgAAAAAAAECCBAAAAAAAAJAgAQAAAAAAACRIAAAAAAAAAAkSAAAAAAAAQIL+P7JkD+72rHUsAAAAAElFTkSuQmCC)"></span>

 

[alfa1]

All files on my server are scanned against base64 use. I disallow it because its often used for hacking. Each time we were hacked we found base64 in our files.
Why is base64 used?