Fixed Group admins can be promoted to Group admin again

[alfa1]

A group admin can be promoted to be group admin. Then the group admin will display in the group staff members block twice.
A user should only be able to be group staff once.

 

[Truonglv]

Weird. I cannot reproduce this issues :/

 

[alfa1]

Try on your server. Not on XAMPP.

 

[Dadparvar]

@alfa1 I tested it here but couldn't reproduce it.

https://nobita.me/groups/dadparvar/feeds
I promoted @Younes to admin a few times but he is only being displayed in the sidebar just once.
Can you reproduce it here?
I tested on my own site as well and couldn't reproduce it.

 

[alfa1]

This is partly fixed. You can still promote to admin twice, but now it doesn't display the group admin member twice.

 

[Truonglv]

This is partly fixed. You can still promote to admin twice, but now it doesn't display the group admin member twice.

alfa1I guess that third party add-on make this issues. Cause it's use user ID as key of data list. Cannot same user in list.

 

[Dadparvar]

Right.

Current role of user should be grayed and disabled to make it clear that the user already has that role.

 

[alfa1]

Current role of user should be grayed and disabled to make it clear that the user already has that role.

DadparvarExactly

 

[alfa1]

Current role of user should be grayed and disabled to make it clear that the user already has that role.

Dadparvar@truonglv please be so kind to implement this fix.

 

[Truonglv]

@truonglv please be so kind to implement this fix.

alfa1It's not bug belong to this add-on. But anyway rebuild groups should fix this issues.

 

[alfa1]

Current role of user should be grayed and disabled to make it clear that the user already has that role.

DadparvarPlease implement this.